Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support libdisplay-info 2.0 (or at least don't link against it incorrectly) #9

Closed
ids1024 opened this issue Jan 3, 2025 · 1 comment · Fixed by #10
Closed

Support libdisplay-info 2.0 (or at least don't link against it incorrectly) #9

ids1024 opened this issue Jan 3, 2025 · 1 comment · Fixed by #10

Comments

@ids1024
Copy link
Member

ids1024 commented Jan 3, 2025

It seems the definition of the di_edid_display_range_limits struct was changed slightly. The ABI seems otherwise unchanged.

https://gitlab.freedesktop.org/emersion/libdisplay-info/-/commit/8aa57fbed9d2a7a3e59c0c19024c43074e47668a

libdisplay-info-sys currently seems to link against display-info 2.0 if present, causing a segfault (or a panic in debug builds): pop-os/cosmic-comp#1020 (comment).

If the crate wants to support both versions, not sure how best to deal with that. I guess it would be possible for build.rs to determine which version its linking against.

@ids1024
Copy link
Member Author

ids1024 commented Jan 3, 2025

Looks like Ubuntu Noble has libdisplay-info1 0.1.1, Oracular has libdisplay-info2 0.2.0. While Debian has libdisplay-info2 in bookworm-backports, trixie, and sid, and doesn't currently seem to package libdisplay-info1 anywhere.

So we'd likely want to support both at present.

@cmeissl cmeissl mentioned this issue Jan 3, 2025
1 task
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant