Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Incorrect disconnect code #146

Open
alexanderbrus opened this issue Jan 10, 2023 · 1 comment
Open

Incorrect disconnect code #146

alexanderbrus opened this issue Jan 10, 2023 · 1 comment

Comments

@alexanderbrus
Copy link

Library ws which used under the hood for node.js clients, does not allow disconnect codes 1004, 1005 and 1006.

But anyway socketcluster-client uses 1005 and 1006 which leads to Uncaught exception: "TypeError: First argument must be a valid error code number" (see, WS Code validation)
@jondubois
Copy link
Member

jondubois commented Jan 21, 2023 •
edited
Loading

@alexanderbrus Which version of socketcluster-client is affected? How to reproduce this issue?

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jondubois @alexanderbrus