Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

server options aren't passed correctly on server.js #41

Open
KaniZ0r opened this issue Feb 4, 2020 · 1 comment
Open

server options aren't passed correctly on server.js #41

KaniZ0r opened this issue Feb 4, 2020 · 1 comment

Comments

@KaniZ0r
Copy link

KaniZ0r commented Feb 4, 2020

Current behaviour

Server options are passed as options parameter to server.js. They are combinet to let opts variable via Object.assign and stored to this.options. Server.js takes options from let opts instead of this.options and this causes many options to be null.

Expected behaviour

Server.js takes options from this.options which contains combined options from let opts and optionsparameter.

@jondubois
Copy link
Member

jondubois commented Feb 4, 2020

@KaniZ0r This shouldn't be a problem because Object.assign mutates the original opts object. So this.options === opts. That said, we can modify the original code to make this more clear. If that's the case, then this is not very high priority but feel free to make a PR.

Did you notice any problems when running the node? Could there be an alternative explanation?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants