Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix socket.kickOut() v17 #51

Merged
merged 2 commits into from
Feb 5, 2023
Merged

fix socket.kickOut() v17 #51

merged 2 commits into from
Feb 5, 2023

Conversation

MegaGM
Copy link
Member

@MegaGM MegaGM commented Jan 31, 2023

closes #49

@MegaGM MegaGM requested a review from jondubois January 31, 2023 05:41
jondubois
jondubois requested changes Jan 31, 2023
View reviewed changes
Copy link
Member

@jondubois jondubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I proposed a change to account for a very specific edge case.
Let me know if you have any thoughts about it. I was thinking it's almost not worth handling but it shouldn't be too difficult to do so.

serversocket.js Outdated Show resolved Hide resolved
@MegaGM MegaGM self-assigned this Feb 2, 2023
@jondubois jondubois merged commit 8fd9492 into SocketCluster:master Feb 5, 2023
@MegaGM MegaGM mentioned this pull request Feb 8, 2023
Merged
8 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jondubois jondubois jondubois requested changes

Assignees

@MegaGM MegaGM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

socket.kickOut fails
2 participants
@MegaGM @jondubois