Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Image is outdated on Docker Hub #4

Open
daniel-lerch opened this issue Jul 4, 2023 · 4 comments
Open

Image is outdated on Docker Hub #4

daniel-lerch opened this issue Jul 4, 2023 · 4 comments

Comments

@daniel-lerch
Copy link

The latest published stable tag on Docker Hub is v4.39-9772-beta.

However, in the meantime there have been three more stable releases:

Will these releases be published to Docker Hub? I'd be happy to contribute a PR if necessary.

@weidi
Copy link
Collaborator

weidi commented Jul 5, 2023

i just pushed the missing stable releases.
Tried to also do this using github CI but was so far not succesfull getting the automatic tagging done so i´m happy if you know how to do it.

@daniel-lerch
Copy link
Author

Thank you very much updating!

In order to help you with the tagging you will have to describe or add to documentation of this repo, how the GitHub Actions CI pipeline is triggered. How do you get the releases from both SoftEther source repositories?

@weidi
Copy link
Collaborator

weidi commented Jul 6, 2023

I was hoping to get this done by tagging a commit with the respective version but receiving
v4.41-9787-rtm is not a valid semver. More info: https://semver.org/

@j123b567
Copy link

As my understanding

  • semver should have 3 digits 4.41.9787 is valid semver, 4.41-9787 is not
  • semver does not know -rtm suffix and it is considered as prerelease
  • semver should not have v prefix

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants