From a668054c5b4bc843be9c833089d0c69815b15c40 Mon Sep 17 00:00:00 2001 From: Yassin Kammoun <52890329+yassin-kammoun-sonarsource@users.noreply.github.com> Date: Fri, 9 Feb 2024 11:30:29 +0100 Subject: [PATCH] Drop Node.js 14 support and test against Node.js 20 on CI (#445) --- .cirrus.yml | 6 +++--- .cirrus/nodejs.Dockerfile | 3 ++- README.md | 2 +- package.json | 2 +- 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index b2bc1dbe..16a15cab 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -51,15 +51,15 @@ qa_task: - build eks_container: matrix: - - docker_arguments: - NODE_VERSION: 14 - CIRRUS_AWS_ACCOUNT: ${CIRRUS_AWS_ACCOUNT} - docker_arguments: NODE_VERSION: 16 CIRRUS_AWS_ACCOUNT: ${CIRRUS_AWS_ACCOUNT} - docker_arguments: NODE_VERSION: 18 CIRRUS_AWS_ACCOUNT: ${CIRRUS_AWS_ACCOUNT} + - docker_arguments: + NODE_VERSION: 20 + CIRRUS_AWS_ACCOUNT: ${CIRRUS_AWS_ACCOUNT} <<: *CONTAINER_DEFINITION cpu: 3 memory: 8G diff --git a/.cirrus/nodejs.Dockerfile b/.cirrus/nodejs.Dockerfile index a4610a9d..2baf4579 100644 --- a/.cirrus/nodejs.Dockerfile +++ b/.cirrus/nodejs.Dockerfile @@ -6,7 +6,8 @@ USER root ARG NODE_VERSION=18 ARG SCANNER_VERSION=5.0.1.3006 -RUN apt-get update && apt-get install -y nodejs=${NODE_VERSION}.* +RUN curl -fsSL https://deb.nodesource.com/setup_${NODE_VERSION}.x | bash - \ + && apt-get install -y nodejs=${NODE_VERSION}.* RUN curl "https://binaries.sonarsource.com/Distribution/sonar-scanner-cli/sonar-scanner-cli-${SCANNER_VERSION}.zip" -o /tmp/sonar-scanner.zip \ && unzip -d /opt /tmp/sonar-scanner.zip \ diff --git a/README.md b/README.md index 74c1f126..be94068b 100644 --- a/README.md +++ b/README.md @@ -81,7 +81,7 @@ Code Smells, or maintainability issues, are raised for places of code which migh ## Prerequisites -- Node.js (>=14.x). +- Node.js (>=16.x). - ESLint 5.x, 6.x, 7.x or 8.x (peer dependency for the plugin). ## Usage diff --git a/package.json b/package.json index 26b71e90..941c3280 100644 --- a/package.json +++ b/package.json @@ -16,7 +16,7 @@ }, "homepage": "https://github.com/SonarSource/eslint-plugin-sonarjs", "engines": { - "node": ">=14" + "node": ">=16" }, "scripts": { "build": "rimraf lib && tsc -d -p tsconfig.json",