Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MAX_CRIT group criterion needs re-implementation #32

Open
lplana opened this issue Aug 28, 2020 · 0 comments
Open

MAX_CRIT group criterion needs re-implementation #32

lplana opened this issue Aug 28, 2020 · 0 comments
Assignees
Labels

Comments

@lplana
Copy link
Member

lplana commented Aug 28, 2020

The MAX_CRIT group criterion is described in the Lens Manual.

This group criterion, implemented in function max_stop_crit() [file process_t.c] needs re-writing as the current implementation only works correctly if only one unit has the largest target, which is not usually the case.

Additionally, as this criterion is based on group-wide values rather than on individual unit ones, the function needs to make a correct distributed decision when the output group is split across multiple subgroups.

@lplana lplana added the bug label Aug 28, 2020
@lplana lplana assigned lplana and unassigned lplana Aug 28, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant