Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move binaries directory under binaries #71

Open
Christian-B opened this issue Apr 5, 2023 · 2 comments
Open

Move binaries directory under binaries #71

Christian-B opened this issue Apr 5, 2023 · 2 comments
Labels

Comments

@Christian-B
Copy link
Member

Christian-B commented Apr 5, 2023

The binaries are currently stored in a directory that not inside (a child directory of) the main spinn_pdp2 directory.

This result in the code only working if installed in developer/ edittable mode.

In developer / editable mode the spinn_pdp2 directory is only referenced not copied into site_packages
Therefor the code
path to binary files
binaries_path = os.path.join(os.path.dirname(file), "..", "binaries")
works.

In a normal install the spinn_pdp2 directory is copied into site_packages.
However the "binaries" directory is not.
It could be but with a generic name like "binaries" this is not recommended.
Also the build would fail it you need sudo access to site_packages.

The PyPA recommends that any data files you wish to be accessible at run time be included inside the package.
ref: https://setuptools.pypa.io/en/latest/userguide/datafiles.html

The fix is to move binaries under spinn_pdp2 and change the code that references it.

@Christian-B Christian-B added the bug label Apr 5, 2023
@Christian-B
Copy link
Member Author

Currently Jenkins works as it can and still does test this repository in editable mode.

So this is not urgent if there are no plans to release the code.

@Christian-B
Copy link
Member Author

if you would like me to do the change Please assign this to me and I will propose a PR.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant