Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bug: context.first_hand_drawn is true when not drawing first hand of round #515

Closed
VictinZero opened this issue Mar 4, 2025 · 0 comments

Comments

@VictinZero
Copy link
Contributor

(Already reported to @Eremel but I wanted to register it in an "official" capacity.)

If an effect triggers a draw by drawing the first hand of round, this can prompt a semi-infinite loop (as long as there are cards in the deck). Presumably because subsequent draws pass context.first_hand_drawn = true. A simple effect that initiates this loop is to obtain a Negative playing card in hand after drawing the first hand of round (creating it ex nihilo or turning an existing held card Negative).

Here lies a small philosophical argument. I think an effect like "When you draw a card, draw a card" causing an infinite loop would be the fault of whoever designed it. However, the condition here is closer to "When you draw your first hand of round, draw a card", and it results in a loop because the presumed context.first_hand_drawn doesn't act as it seems like it should act.

An easy solution would be to add a new (global?) boolean variable to track if any hands have been drawn in the round, and assign its value to context.first_hand_drawn.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant