Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update local build instructions and README #266

Closed
wants to merge 8 commits into from

Conversation

ccheetham
Copy link
Contributor

@ccheetham ccheetham commented Jun 6, 2022

  • remove details of DocFX configuration; defer to DocFX docs
  • rename main site configuration files to be main-site*.json
  • provide a local Docker image to run DocFX as a convenience
  • fixes Local Docker Build does not work #263

@ccheetham ccheetham requested review from TimHess and bart-vmware June 6, 2022 12:53
README.md Outdated Show resolved Hide resolved
TimHess
TimHess previously approved these changes Jun 6, 2022
@bart-vmware
Copy link
Member

Thanks @ccheetham!

I'm going to try this out out after #265 and #264 have been merged.

@ccheetham ccheetham marked this pull request as draft June 8, 2022 11:28
@bart-vmware bart-vmware mentioned this pull request Jun 8, 2022
@bart-vmware
Copy link
Member

If this solves #263, can you link to it from the PR description, so it auto-closes on merge?

@ccheetham
Copy link
Contributor Author

Waiting on #264

@bart-vmware
Copy link
Member

@ccheetham Can you please go ahead and resolve the merge issues and verify this PR is still accurate?

ccheetham and others added 8 commits January 31, 2024 15:33
* remove details of DocFX configuration; defer to DocFX docs
* rename main site configuration files to be main-site*.json
* provide a local Docker image to run DocFX as a convenience
* remove details of DocFX configuration; defer to DocFX docs
* rename main site configuration files to be main-site*.json
* provide a local Docker image to run DocFX as a convenience
@TimHess TimHess force-pushed the ccheetham/update-local-build-readme branch from 5d4a0a8 to 75f943e Compare January 31, 2024 21:34
@TimHess
Copy link
Member

TimHess commented Feb 5, 2024

These updates will now be included with #312, along with GH actions to build on top

@TimHess TimHess closed this Feb 5, 2024
@TimHess TimHess deleted the ccheetham/update-local-build-readme branch February 13, 2024 17:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local Docker Build does not work
3 participants