Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Example of Service Discovery seems incorrect #305

Open
dingmeng-xue opened this issue Nov 2, 2023 · 1 comment
Open

Example of Service Discovery seems incorrect #305

dingmeng-xue opened this issue Nov 2, 2023 · 1 comment
Labels

Comments

@dingmeng-xue
Copy link

dingmeng-xue commented Nov 2, 2023

Describe the bug

I try to follow this instruction https://docs.steeltoe.io/guides/service-discovery/eureka.html?tabs=cli, but am pretty confused. It seems there are some issues. For instance, launchSettings.json is different. what's api/values url? Doc says it is http://localhost:8080/api/values but it is http://localhost:8080/WeatherForecast

If you click Looking for additional params to use when connecting? Have a look at the docs)., you get 404 error.

Steps to reproduce

NA

Expected behavior

I assume I should follow this tutorial strictly and get successful result without any additional change.

Environment (please complete the following information):

  • Sample name: [e.g. RabbitMQ Connector, Discovery, etc.]
  • Platform: [e.g. Cloud Foundry, Azure, etc.)
  • OS: [e.g. Windows, Linux, Mac OSX]
  • .NET Version [e.g. .NET Core 2.1.0, .NET Framework 4.7.1, etc.]
  • Steeltoe Version [e.g. 2.3.0]
  • Any other library versions to note

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context or links

Add any other context about the problem here.

@TimHess
Copy link
Member

TimHess commented Nov 2, 2023

Hi @dingmeng-xue,

Thanks for opening the issue, you're correct that there are definitely some problems with that guide, and I think there are going to be other issues that will come to light quickly if .NET 8 is used, so we're going to need to prioritize #229 sooner rather than later. FYI, I'm also going to move this issue to the Documentation repo.

In the interest of getting you up and running quickly:

  • That broken link should go here
  • Port 8080 will become the default if you also add the Cloud Hosting dependency
  • /api/values comes from an older template, it should be /Weatherforecast now
  • The samples in this folder should work with less effort

@TimHess TimHess transferred this issue from SteeltoeOSS/Samples Nov 2, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants