Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Templating doesn't work reliably without a .regal directory #1164

Closed
anderseknert opened this issue Oct 2, 2024 · 1 comment · Fixed by #1171
Closed

Templating doesn't work reliably without a .regal directory #1164

anderseknert opened this issue Oct 2, 2024 · 1 comment · Fixed by #1171
Labels
bug Something isn't working language server protocol

Comments

@anderseknert
Copy link
Member

It seems like the templating of new files imposed by directory-structure-mismatch doesn't work very well unless there is a .regal directory to pin the workspace root to. Since this is going to be the first impression many will get of Regal, it should be fixed before next release.
@anderseknert anderseknert added bug Something isn't working language server protocol labels Oct 2, 2024
@anderseknert
Copy link
Member Author

#1141 certainly related, so might be a good idea to look at both at the same time.

charlieegan3 added a commit to charlieegan3/regal that referenced this issue Oct 3, 2024
@charlieegan3
lsp/templating: gracefully unknown root
932aa9c 
This also disables templating for files in the root.

Fixes StyraInc#1164

Related to StyraInc#1141, but this needs
more work

Signed-off-by: Charlie Egan <charlie@styra.com>
@charlieegan3 charlieegan3 mentioned this issue Oct 3, 2024
Merged
charlieegan3 added a commit to charlieegan3/regal that referenced this issue Oct 7, 2024
@charlieegan3
lsp/templating: gracefully unknown root
9dbd651 
This also disables templating for files in the root.

Fixes StyraInc#1164

Related to StyraInc#1141, but this needs
more work

Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3 added a commit to charlieegan3/regal that referenced this issue Oct 7, 2024
@charlieegan3
lsp/templating: gracefully unknown root
f218a3a 
This also disables templating for files in the root.

Fixes StyraInc#1164

Related to StyraInc#1141, but this needs
more work

Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3 added a commit to charlieegan3/regal that referenced this issue Jan 6, 2025
@charlieegan3
lsp/templating: gracefully handle unknown root (StyraInc#1171)
cfa43ff 
* lsp/templating: gracefully unknown root

This also disables templating for files in the root.

Fixes StyraInc#1164

Related to StyraInc#1141, but this needs
more work

Signed-off-by: Charlie Egan <charlie@styra.com>

* Guard rather than use error control flow

Signed-off-by: Charlie Egan <charlie@styra.com>

* Correct test error message

Signed-off-by: Charlie Egan <charlie@styra.com>

---------

Signed-off-by: Charlie Egan <charlie@styra.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working language server protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lsp/templating: gracefully handle unknown root charlieegan3/regal
1 participant
@anderseknert