Skip to content

Commit 115893f

Browse files
committed
told the user the interview url and closes #696
1 parent fb7bb3b commit 115893f

File tree

4 files changed

+18
-10
lines changed

4 files changed

+18
-10
lines changed

CHANGELOG.md

+3-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,9 @@ Format:
4242
### Internal
4343
-
4444
-->
45-
<!-- ## [Unreleased] -->
45+
## [Unreleased]
46+
### Changed
47+
- Told the user the interview url. See https://github.com/SuffolkLITLab/ALKiln/issues/696.
4648

4749
## [5.2.0] - 2023-09-16
4850
### Changed

docassemble/ALKilnTests/data/sources/establishing_steps.feature

+2-2
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ Scenario: I want to go to a full arbitrary url
4141
Given the max seconds for each step in this scenario is 5
4242
And the Scenario report should include:
4343
"""
44-
Trying to load the interview
44+
Trying to load the interview at "https://apps-test.suffolklitlab.org/start/demo/questions"
4545
"""
4646
  Given I start the interview at "https://apps-test.suffolklitlab.org/start/demo/questions"
4747
  Then I should see the phrase "What language do you speak?"
@@ -52,7 +52,7 @@ Scenario: Fail with no interview at arbitrary url
5252
Given the final Scenario status should be "failed"
5353
And the Scenario report should include:
5454
"""
55-
Trying to load the interview
55+
Trying to load the interview at "https://apps-test.suffolklitlab.org/list"
5656
"""
5757
And the Scenario report should include:
5858
"""

docassemble/ALKilnTests/data/sources/reports.feature

+8-1
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,14 @@ Scenario: Report still shows page id when I tap to continue without setting any
460460
Scenario: Report still shows page id when I tap to continue without setting any fields
461461
Tags: @reports @fast @rp1
462462
---------------
463-
Trying to load the interview
463+
Trying to load the interview at "
464+
"""
465+
Given the Scenario report should include:
466+
"""
467+
all_tests.yml"
468+
"""
469+
Given the Scenario report should include:
470+
"""
464471
screen id: upload-files
465472
screen id: group-of-complex-fields
466473
| double_quote_dict['double_quote_key']['dq_two'] | true | |

lib/scope.js

+5-6
Original file line numberDiff line numberDiff line change
@@ -732,11 +732,6 @@ module.exports = {
732732
/* Try to load the page. Should we also pass a `timeout` arg or just
733733
* use scope.timeout? */
734734

735-
await scope.addToReport(scope,{
736-
type: `row`,
737-
value: `Trying to load the interview`
738-
});
739-
740735
let interview_url = null;
741736
// If the file is already a full url, just use that arbitrary url
742737
if ( /^http/.test( file_name ) ) {
@@ -752,7 +747,11 @@ module.exports = {
752747
let base_url = await get_base_interview_url();
753748
interview_url = `${ base_url }${ file_name }`;
754749
}
755-
if ( session_vars.get_debug() ) { console.log( `interview_url:`, interview_url ); }
750+
751+
await scope.addToReport(scope,{
752+
type: `row`,
753+
value: `Trying to load the interview at "${interview_url}"`
754+
});
756755

757756
if ( !scope.page ) { scope.page = await scope.browser.newPage(); }
758757

0 commit comments

Comments
 (0)