Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Internal: github server workflow enable tmate input is breaking manually run tests #828

Open
plocket opened this issue Dec 5, 2023 · 0 comments · May be fixed by #829
Open

Internal: github server workflow enable tmate input is breaking manually run tests #828

plocket opened this issue Dec 5, 2023 · 0 comments · May be fixed by #829
Assignees
@plocket

Comments

@plocket
Copy link
Collaborator

plocket commented Dec 5, 2023 •
edited
Loading

After some research, it seems like input values are still strings, even if their type is boolean: https://github.blog/changelog/2021-11-10-github-actions-input-types-for-manual-workflows/. Also https://github.com/orgs/community/discussions/29796. We have to account for that in our workflow file.

[I'm still not sure why if: ${{ input.enable_tmate }} would have a problem. I thought GitHub action ifs coerced that type of value.]
@plocket plocket linked a pull request Dec 5, 2023 that will close this issue
Draft
3 tasks
@plocket plocket self-assigned this Apr 23, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@plocket plocket

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Internal: Fix wrong input type being used in our github server workflow file SuffolkLITLab/ALKiln
1 participant
@plocket