Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use modern JS in app.js of project templates #251

Open
samajammin opened this issue Jun 2, 2020 · 4 comments
Open

Use modern JS in app.js of project templates #251

samajammin opened this issue Jun 2, 2020 · 4 comments

Comments

@samajammin
Copy link
Collaborator

Summary

Refactor app.js files to use modern syntax - const/let vs. var & async/await.

Motivation

  • Demonstrate the Ethereum stack is up to date with latest development approaches
  • Reduce boilerplate of callbacks so users can focus on the web3 logic

Describe alternatives you've considered

Additional context

@nathan-lapinski
Copy link
Contributor

Hey @samajammin , are you accepting PRs for either of this or #243 ?
If so, I'd be happy to try submitting a PR using either approach.

I think I could make pretty quick work of updating the templates to use React, if that's a library that you all would be happy with using.

I'd also be happy to just start out by updating the app.js files to use more modern JS syntax, now that #228 #207 are just about done.

@samajammin
Copy link
Collaborator Author

Thanks again @nathan-lapinski! I believe the team would welcome additional PRs 😄

I think I could make pretty quick work of updating the templates to use React, if that's a library that you all would be happy with using.

That's certainly our vision (see #243). If you think it'd be quick work, I'd say go for it! Otherwise I think this issue to update to more modern JS would be a great start.

@javier-tarazaga
Copy link
Contributor

Hi @nathan-lapinski!

All contributions are always more than welcome :) Originally we thought of that implementation as codesanbox/stackblitz do it, by adding support to npm packages in the FE. Said this, this can be a draconian task to do. Any other way which can get us one step closer to support any FE frameworks like React, Vue, Angular, etc is always more than welcomed.

@nathan-lapinski
Copy link
Contributor

Thanks @samajammin @javier-tarazaga !! I will start to look into this. I might just start with updating the app.js files to use more modern JS, since that should be a relatively quick win, and would be independent of any framework.

After that, I'd definitely like to look into #243 more 😄

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants