Always log specific update job failure

schroda · schroda · commit 7c390caca95a · 2023-10-24T22:00:46.000+02:00
diff --git a/server/src/main/kotlin/suwayomi/tachidesk/manga/impl/update/Updater.kt b/server/src/main/kotlin/suwayomi/tachidesk/manga/impl/update/Updater.kt
@@ -200,8 +200,8 @@ class Updater : IUpdater {
                 Chapter.getChapterList(job.manga.id, true)
                 job.copy(status = JobStatus.COMPLETE)
             } catch (e: Exception) {
-                if (e is CancellationException) throw e
                 logger.error(e) { "Error while updating ${job.manga.title}" }
+                if (e is CancellationException) throw e
                 job.copy(status = JobStatus.FAILED)
             }
 

Original file line number	Diff line number	Diff line change
`@@ -200,8 +200,8 @@ class Updater : IUpdater {`
`200`	`200`	`Chapter.getChapterList(job.manga.id, true)`
`201`	`201`	`job.copy(status = JobStatus.COMPLETE)`
`202`	`202`	`} catch (e: Exception) {`
`203`		`- if (e is CancellationException) throw e`
`204`	`203`	`logger.error(e) { "Error while updating ${job.manga.title}" }`
	`204`	`+ if (e is CancellationException) throw e`
`205`	`205`	`job.copy(status = JobStatus.FAILED)`
`206`	`206`	`}`
`207`	`207`