Always log specific update job failure

schroda · schroda · commit 9b7fb812b0a5 · 2023-10-24T22:06:14.000+02:00
diff --git a/server/src/main/kotlin/suwayomi/tachidesk/manga/impl/update/Updater.kt b/server/src/main/kotlin/suwayomi/tachidesk/manga/impl/update/Updater.kt
@@ -197,8 +197,8 @@ class Updater : IUpdater {
                 Chapter.getChapterList(job.manga.id, true)
                 job.copy(status = JobStatus.COMPLETE)
             } catch (e: Exception) {
-                if (e is CancellationException) throw e
                 logger.error(e) { "Error while updating ${job.manga.title}" }
+                if (e is CancellationException) throw e
                 job.copy(status = JobStatus.FAILED)
             }
 

Original file line number	Diff line number	Diff line change
`@@ -197,8 +197,8 @@ class Updater : IUpdater {`
`197`	`197`	`Chapter.getChapterList(job.manga.id, true)`
`198`	`198`	`job.copy(status = JobStatus.COMPLETE)`
`199`	`199`	`} catch (e: Exception) {`
`200`		`- if (e is CancellationException) throw e`
`201`	`200`	`logger.error(e) { "Error while updating ${job.manga.title}" }`
	`201`	`+ if (e is CancellationException) throw e`
`202`	`202`	`job.copy(status = JobStatus.FAILED)`
`203`	`203`	`}`
`204`	`204`