Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Adding a paragraph about branch name conventions used in SwiftGen #298

Merged
merged 3 commits into from
May 7, 2017
Merged

Adding a paragraph about branch name conventions used in SwiftGen #298

merged 3 commits into from
May 7, 2017

Conversation

AliSoftware
Copy link
Collaborator

@AliSoftware AliSoftware commented May 7, 2017 •
edited
Loading

  • I've added an entry in the CHANGELOG.md file to explain my changes and credit myself
    • Add the entry in the appropriate section (Bug Fix / New Feature / Breaking Change / Internal Change)
    • Add a period and 2 spaces at the end of your short entry description
    • Add links to your GitHub profile to credit yourself and to the related PR and issue after your description

djbe
djbe requested changes May 7, 2017
View reviewed changes
Copy link
Member

@djbe djbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the other sections have the first letter of each word uppercased

@AliSoftware AliSoftware force-pushed the feature/branch-name-convention branch from af7b763 to 73db428 Compare May 7, 2017 22:07
@AliSoftware AliSoftware merged commit d79f8a3 into master May 7, 2017
@AliSoftware AliSoftware deleted the feature/branch-name-convention branch May 7, 2017 22:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@djbe djbe djbe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AliSoftware @djbe