Skip to content
This repository has been archived by the owner on Sep 6, 2018. It is now read-only.

allow access to name property on color assets #87

Merged

Conversation

diederich
Copy link
Contributor

allow access to the name of the color asset,
e.g. to show a list of all colors used in the app.
See #85 for the same on images.

allow access to the name of the color asset,
e.g. to show a list of all colors used in the app.
See SwiftGen#85 for the same on images.
@AliSoftware
Copy link
Collaborator

Hey @diederich !

Thanks for the PR 😃
Pleanse add an entry in the CHANGELOG to credit yourself for that change (don't forget to add two spaces after the period at the end of the description line)

@AliSoftware
Copy link
Collaborator

AliSoftware commented Oct 31, 2017

Ah, nitpicking, but… the other PR added that entry into "Bug Fixes" 😆
I'm not sure where we should really put that kind of change ("Bug Fixes" like the other one, or "New Features" like you did), I think both are equally valid for this… but at least it would be nice to be consistent are they are clearly related 😉

@diederich
Copy link
Contributor Author

Agreed. I wondered why it was in bug fixing, and just put it in features.

@AliSoftware
Copy link
Collaborator

Perfect 👌 thanks again!

@AliSoftware AliSoftware merged commit 366a1d8 into SwiftGen:master Oct 31, 2017
@diederich diederich deleted the feature/allow-color-name-access branch November 1, 2017 09:59
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants