Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor ingestor job system #72

Open
consolethinks opened this issue Jan 23, 2025 · 1 comment
Open

Refactor ingestor job system #72

consolethinks opened this issue Jan 23, 2025 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@consolethinks
Copy link
Collaborator

The ingestor job system currently can spawn an infinite number of go routines whose only job is to wait until a worker can consume their job on the ingestion task channel. Maybe this needs to be changed to avoid running out of memory.

The bigger issue right now is that if we start using access tokens sent by users for ingestion tasks, then those tasks can't wait for too long. This needs to be addressed in some way (eg. checking if there's a worker available before accepting a task)

@consolethinks consolethinks added the enhancement New feature or request label Jan 23, 2025
@phwissmann
Copy link
Collaborator

For the first issue, we can either just use a workpool like Pond https://github.com/alitto/pond or a more elaborate task system/scheduler. I think a workpool is the minimum we should do.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants