-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Maintenance][Refactor] Bump plugin to 1.14 #331
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpysiak
force-pushed
the
SYL-4029-bump-plugin-to-1.14
branch
2 times, most recently
from
November 5, 2024 10:45
1ff9a8f
to
7eaa18d
Compare
mpysiak
force-pushed
the
SYL-4029-bump-plugin-to-1.14
branch
from
November 5, 2024 10:45
7eaa18d
to
661274c
Compare
GSadee
reviewed
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an UPGRADE file with information on significant changes, such as drop Sylius 1.12, removing deprecations, etc
mpysiak
force-pushed
the
SYL-4029-bump-plugin-to-1.14
branch
from
November 6, 2024 09:27
bb4430d
to
fbcf866
Compare
mpysiak
force-pushed
the
SYL-4029-bump-plugin-to-1.14
branch
from
November 6, 2024 09:30
fbcf866
to
25491b0
Compare
GSadee
approved these changes
Nov 6, 2024
@@ -19,43 +19,32 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
php: ["8.1", "8.2"] | |||
php: ["8.3"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO the single builds for PHP 8.1 and 8.2 should stay
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.