Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Order] Fix race condition problem with multiple order recalculations #12558

Merged
merged 2 commits into from
Apr 26, 2021
Merged

[Order] Fix race condition problem with multiple order recalculations #12558

merged 2 commits into from
Apr 26, 2021

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Apr 23, 2021 •
edited
Loading

Q A
Branch? 1.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

While testing many requests in a short time to change the quantity of product in the cart, I detected 2 problems:

  • an incorrect number of order item units in relation to the quantity on order item
  • an incorrect adjustments total

This PR solves these two issues.

@GSadee GSadee added the Bug Confirmed bugs or bugfixes. label Apr 23, 2021
@GSadee GSadee requested a review from a team as a code owner April 23, 2021 11:23
@GSadee GSadee changed the title [Order] Fix race condition problem with multiple recalculation order [Order] Fix race condition problem with multiple order recalculations Apr 23, 2021
@AdamKasp AdamKasp merged commit 41297a9 into Sylius:1.8 Apr 26, 2021
@AdamKasp
Copy link
Contributor

Thank you, Grzegorz! 🎉

@GSadee GSadee deleted the recalculation-problem branch April 26, 2021 06:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

@AdamKasp AdamKasp AdamKasp approved these changes

Assignees
No one assigned
Labels
Bug Confirmed bugs or bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GSadee @AdamKasp @lchrusciel