[Admin][UI][API] Reset password validation #14153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
Admin
NoResponseMate
force-pushed
the
admin-password-reset-validation-actual
branch
3 times, most recently
from
cfc91f5 to
6bab102
Compare
TheMilek
approved these changes
Jul 21, 2022
src/Sylius/Behat/Context/Api/Admin/ResettingPasswordContext.php
Outdated
Show resolved
Hide resolved
GSadee
approved these changes
Jul 21, 2022
...Sylius/Bundle/ApiBundle/Validator/Constraints/AdminResetPasswordTokenNonExpiredValidator.php
Show resolved
Hide resolved
Zales0123
approved these changes
Jul 21, 2022
src/Sylius/Bundle/AdminBundle/Action/Account/RenderResetPasswordPageAction.php
Show resolved
Hide resolved
Remove redunant ResetPasswordDispatcherSpec method
[Behat] Extracted duplicated reset action from pages to an element
NoResponseMate
force-pushed
the
admin-password-reset-validation-actual
branch
from
6bab102 to
fd24b11
Compare
|
Thank you, Jan! 🎉 |
Zales0123
added a commit
that referenced
this pull request
Jul 22, 2022
…sponseMate) This PR was merged into the 1.12 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.12 | | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> | | Related tickets | - | | License | MIT | Applies leftover review comments from #14153 and #14147 Commits ------- 9f4c335 [Behat][Admin] A small cleanup of password reset related stuff ccfdbe2 [Maintenance][Admin] Extracted expired password request handling
|
@TheMilek @GSadee @Zales0123 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #14147
Extracted it to not mix the concepts as the base PR only touches UI, but the validation is for both UI and API.