Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add php-http/message-factory as a dev dependency to fix tests #15048

Merged
merged 1 commit into from
May 17, 2023

Conversation

jakubtobiasz
Copy link
Contributor

Q A
Branch? 1.12
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

In php-http/message:1.16.0 the package php-http/message-factory has been removed from the list of dependencies. We use it to check backward compatibility, so I added it as a dev deps to AdminBundle, what will fix our CI.

@jakubtobiasz jakubtobiasz requested a review from a team as a code owner May 17, 2023 13:55
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label May 17, 2023
@jakubtobiasz jakubtobiasz added Maintenance CI configurations, READMEs, releases, etc. CI Issues and PRs related to automated testing and removed Admin AdminBundle related issues and PRs. labels May 17, 2023
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label May 17, 2023
@NoResponseMate NoResponseMate merged commit 10c6687 into Sylius:1.12 May 17, 2023
@NoResponseMate
Copy link
Contributor

Thank you, @jakubtobiasz!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Admin AdminBundle related issues and PRs. CI Issues and PRs related to automated testing Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants