Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

CI runs with petric.py from main #118

Closed
KrisThielemans opened this issue Sep 29, 2024 · 1 comment · May be fixed by #119
Closed

CI runs with petric.py from main #118

KrisThielemans opened this issue Sep 29, 2024 · 1 comment · May be fixed by #119
Assignees
@KrisThielemans @casperdcl
Labels
wontfix This will not be worked on

Comments

@KrisThielemans
Copy link
Member

PETRIC/.github/workflows/run.yml

Line 36 in e549237

curl -fsSL https://raw.githubusercontent.com/SyneRBI/PETRIC/main/petric.py > petric.py

@KrisThielemans KrisThielemans self-assigned this Sep 29, 2024
@KrisThielemans KrisThielemans mentioned this issue Sep 29, 2024
Merged
@KrisThielemans KrisThielemans linked a pull request Sep 29, 2024 that will close this issue
add FOV_mask to Dataset #116
Merged
@KrisThielemans KrisThielemans removed a link to a pull request Sep 29, 2024
add FOV_mask to Dataset #116
Merged
@KrisThielemans KrisThielemans mentioned this issue Sep 29, 2024
Open
@casperdcl casperdcl self-assigned this Sep 30, 2024
@casperdcl casperdcl added the wontfix This will not be worked on label Sep 30, 2024
@casperdcl
Copy link
Member

casperdcl commented Sep 30, 2024 •
edited
Loading

we need this line to overwrite any users' changes as per the README

Any modifications to petric.py are ignored.

Yes, all submission repos are a fork of this one, so they all use this run.yml.

  • pro: we all use the same petric.py
  • con: it's impossible for organisers to test changes to petric.py in CI
    • I've had to manually test any change(s)

We could de-sync forks from this repo (have different run.yml), but I'd rather not (it might confuse participants).

@casperdcl casperdcl closed this as not planned Won't fix, can't repro, duplicate, stale Sep 30, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@KrisThielemans KrisThielemans

@casperdcl casperdcl

Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

More CI checks SyneRBI/PETRIC
2 participants
@KrisThielemans @casperdcl