Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Propagate HTTP exceptions upstream instead of catching and returning it #181

Open
traut opened this issue Mar 25, 2015 · 0 comments
Open

Propagate HTTP exceptions upstream instead of catching and returning it #181

traut opened this issue Mar 25, 2015 · 0 comments

Comments

@traut
Copy link
Contributor

traut commented Mar 25, 2015

libtaxii.clients.call_taxii_service2 catches urllib2.HTTPError and returns it as a normal result (https://github.com/TAXIIProject/libtaxii/blob/master/libtaxii/clients.py#L344). This way the exception is masked and user is forced to check returned object type.

A pythonistic and simple solution here would be to re-raise this exception as is or wrapped in custom libtaxii-specific exception.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@traut