TanStack/Start doesn't check types by default, thus many of your own examples are filled with type errors

[bhouston]

Which project does this relate to?

Start

Describe the bug

The nature of the TanStack/Start vinxi dev and vinxi build tools is that the code is not type checked. This leads to type errors creeping in unnoticed. The examples also do not contains a "typecheck" script that would hint to people that there is no type checking by default.

So many TanStack/Start projects are filled with unsurfaced type errors. This undermines so much of the type safety advantages than TanStack/Router offer.

Your Example Website or App

https://github.com/tanstack/router/tree/main/examples/react/start-basic-auth

Steps to Reproduce the Bug or Issue

For example:

https://github.com/tanstack/router/tree/main/examples/react/start-basic-auth

I did the following:

pnpm install
pnpm prisma-generate
npx tsc

And got this result:

app/components/#.tsx(12,5): error TS2322: Type 'OptionalFetcher<undefined, (d: any) => { email: string; password: string; }, { error: boolean; userNotFound: boolean; message: "User not found"; } | { error: boolean; message: "Incorrect password"; userNotFound?: undefined; } | undefined>' is not assignable to type '(variables: unknown) => Promise<unknown>'.
  Types of parameters 'options' and 'variables' are incompatible.
    Type 'unknown' is not assignable to type 'OptionalFetcherDataOptions<undefined, (d: any) => { email: string; password: string; }, false> | undefined'.
app/components/#.tsx(14,22): error TS2339: Property 'error' does not exist on type '{}'.
app/components/#.tsx(23,5): error TS2322: Type '(options?: OptionalFetcherDataOptions<undefined, (d: any) => { email: string; password: string; redirectUrl?: string; }, boolean> | undefined) => Promise<...> | Promise<...>' is not assignable to type '(variables: OptionalFetcherDataOptions<undefined, (d: any) => { email: string; password: string; redirectUrl?: string; }, boolean> | undefined) => Promise<...>'.
  Type 'Promise<FullFetcherData<undefined, { error: boolean; userExists: boolean; message: "User already exists"; }>> | Promise<{ error: boolean; userExists: boolean; message: "User already exists"; }>' is not assignable to type 'Promise<FullFetcherData<undefined, { error: boolean; userExists: boolean; message: "User already exists"; }>>'.
    Type 'Promise<{ error: boolean; userExists: boolean; message: "User already exists"; }>' is not assignable to type 'Promise<FullFetcherData<undefined, { error: boolean; userExists: boolean; message: "User already exists"; }>>'.
      Type '{ error: boolean; userExists: boolean; message: "User already exists"; }' is missing the following properties from type 'FullFetcherData<undefined, { error: boolean; userExists: boolean; message: "User already exists"; }>': result, context
app/components/#.tsx(43,63): error TS2339: Property 'message' does not exist on type '{}'.
app/components/#.tsx(44,33): error TS2339: Property 'userNotFound' does not exist on type '{}'.
app/routes/_authed.tsx(8,15): error TS7006: Parameter 'd' implicitly has an 'any' type.
app/routes/#.tsx(10,6): error TS7006: Parameter 'd' implicitly has an 'any' type.
app/routes/#.tsx(76,5): error TS2322: Type '(options?: OptionalFetcherDataOptions<undefined, (d: any) => { email: string; password: string; redirectUrl?: string; }, boolean> | undefined) => Promise<...> | Promise<...>' is not assignable to type '(variables: OptionalFetcherDataOptions<undefined, (d: any) => { email: string; password: string; redirectUrl?: string; }, boolean> | undefined) => Promise<...>'.
  Type 'Promise<FullFetcherData<undefined, { error: boolean; userExists: boolean; message: "User already exists"; }>> | Promise<{ error: boolean; userExists: boolean; message: "User already exists"; }>' is not assignable to type 'Promise<FullFetcherData<undefined, { error: boolean; userExists: boolean; message: "User already exists"; }>>'.
    Type 'Promise<{ error: boolean; userExists: boolean; message: "User already exists"; }>' is not assignable to type 'Promise<FullFetcherData<undefined, { error: boolean; userExists: boolean; message: "User already exists"; }>>'.
      Type '{ error: boolean; userExists: boolean; message: "User already exists"; }' is missing the following properties from type 'FullFetcherData<undefined, { error: boolean; userExists: boolean; message: "User already exists"; }>': result, context
app/routes/#.tsx(96,64): error TS2339: Property 'message' does not exist on type 'FullFetcherData<undefined, { error: boolean; userExists: boolean; message: "User already exists"; }>'.
app/utils/session.ts(10,21): error TS2558: Expected 0 type arguments, but got 1.

Expected behavior

I would expect that vinxi dev and vinxi build would run TypeScript type checking unless you opted out of it.

Screenshots or Videos

No response

Platform

• OS: MacOS
• Browser: n/a
• Version: 1.104.3, but I Suspect it has affected a bunch.

Additional context

No response