Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feat [#23] SplashView UI 구현 #24

Merged
merged 3 commits into from
May 10, 2024
Merged

Feat [#23] SplashView UI 구현 #24

merged 3 commits into from
May 10, 2024

Conversation

kim-seonwoo
Copy link
Member

👾 작업 내용

  • SplashView의 lottieView를 구현하였습니다.
        .onAppear {
            DispatchQueue.main.asyncAfter(deadline: .now() + 3.5, execute: {
                isLoading.toggle()
            })
        }

3.5초가 원본의 애니메이션 시간인 것 같습니다! 살짝 긴감이 없지 않아있긴합니다!
바인딩된 isLoading를 toggle시킴으로서 화면을 전환시킵니다.

  • 앱 아이콘 수정
  • 로그인 뷰 설명 2번째 이미지 교체

🚀 PR Point

  • 기기대응에 대한 고민

📸 스크린샷

구현 내용 스크린샷
스플래시 Simulator Screen Recording - iPhone 13 mini - 2024-05-09 at 17 12 54

✅ CheckList

  • 오류 없이 빌드되는지 확인
  • 로그용 print문 제거
  • 불필요한 주석 제거
  • 코드 컨벤션 확인

🔗 Issue

Resolved #23

@kim-seonwoo kim-seonwoo added 😎선우 선우의 issue ✨FEAT 기능 구현 🔧FIX 오류 고치는 것 / 수정용 labels May 9, 2024
@kim-seonwoo kim-seonwoo added this to the 🔭2차 스프린트🪐 milestone May 9, 2024
@kim-seonwoo kim-seonwoo requested a review from Zoe0929 May 9, 2024 08:23
@kim-seonwoo kim-seonwoo self-assigned this May 9, 2024
@kim-seonwoo kim-seonwoo linked an issue May 9, 2024 that may be closed by this pull request
Copy link
Member

@Zoe0929 Zoe0929 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 굳굳 입니다 ~ SE나 노치 있는 기기 한 번만 확인해보고 바로 머지하셔도 좋습니다~

@kim-seonwoo kim-seonwoo merged commit 8f6617b into develop May 10, 2024
@Zoe0929 Zoe0929 deleted the feat/#23-SplashView branch June 19, 2024 02:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
✨FEAT 기능 구현 🔧FIX 오류 고치는 것 / 수정용 😎선우 선우의 issue
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feat] 스플래시 뷰 & 로고 추가
2 participants