[Feat/#21] 챌린지뷰 구현 및 스크린타임 API 연결 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kim-seonwoo
approved these changes
May 13, 2024
|
|
||
|
|
||
| class ScreenTimeViewModel: ObservableObject { | ||
| static let shared = ScreenTimeViewModel() |
There was a problem hiding this comment.
💊 싱글톤 객체로 생성하는 것 이외에,
@StateObject var viewModel = ScreenTimeViewModel()
이렇게 선언해서 받아주는 방법도 있더라고요~!
There was a problem hiding this comment.
여러 뷰에서 공용으로 사용해야해서 싱글톤으로 해봤는데, 이 방법이 더 좋은 것 같네요 굳굳!
|
|
||
| struct PointView: View { | ||
| @State var viewModel = PointViewModel() | ||
| var challengeDay = 14 |
There was a problem hiding this comment.
💊 ChallengeDay 변수와 관련 로직을 ViewModel로 분리해도 좋을 것 같아요!!
There was a problem hiding this comment.
오우 이런 실수를! 뷰 모델로 보내겠습니다!
Comment on lines
+22
to
+24
| public init(viewModel: ChallengeViewModel) { | ||
| self.viewModel = viewModel | ||
| } |
There was a problem hiding this comment.
💊 @ObservedObject, @StateObject 같은 것도 고려해보면 좋을 것 같아요!
There was a problem hiding this comment.
이 부분은 다음 PR에서 의존성 주입 고려하면서 다시 작성해볼게요!
kim-seonwoo
approved these changes
May 14, 2024
| import FamilyControls | ||
|
|
||
| struct ChallengeView: View { | ||
| @StateObject var screenTimeViewMode = ScreenTimeViewModel() |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👾 작업 내용
DeviceActivityReportextension 구현🚀 PR Point
HMH_iOS/HMH_iOS/HMH_iOS/Presentation/Challenge/ViewModels/ScreenTimeViewModel.swift
Lines 14 to 15 in b87f78a
DeviceActivityReport외부의 타겟으로 앱 사용량 정보 전송이 어려워서 타겟 안에서 구현하는 것으로 옮기는 작업 중입니다. 해당 부분은 아직 완벽하게 구현되지는 않아, 구현 완료 되면 다시 공유드리겠습니다.HMH_iOS/HMH_iOS/HMHDeviceActivityReport/HMHDeviceActivityReport.swift
Lines 15 to 20 in 2442fe9
HMH_iOS/HMH_iOS/HMH_iOS/Presentation/Challenge/Views/ChallengeView.swift
Lines 86 to 89 in 2442fe9
📸 스크린샷
✅ CheckList
🔗 Issue
Resolved #21