Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feat [#44] 로직 점검 및 앱 잠금 연결 #49

Merged
merged 8 commits into from
Jun 7, 2024
Merged

Conversation

Zoe0929
Copy link
Member

@Zoe0929 Zoe0929 commented Jun 7, 2024

👾 작업 내용

실험 실패로 인한,, 한번 합치고 다시 작업하는 것이 좋을 것 같아서 PR 올립니다!
크게 바뀐 것은 없으나 많은 작업들이 섞여 있어서 조금 복잡합니다. 본래 이슈와 조금 달라진 점 양해 부탁드립니다 😭

🚀 PR Point

푸시 알림 데이터에 앱 관련 정보를 담을 수 있을지 고려해봅시다~

✅ CheckList

  • 오류 없이 빌드되는지 확인
  • 로그용 print문 제거
  • 불필요한 주석 제거
  • 코드 컨벤션 확인

🔗 Issue

Resolved #44

@Zoe0929 Zoe0929 added 🐰지희 지희의 issue ✨FEAT 기능 구현 labels Jun 7, 2024
@Zoe0929 Zoe0929 requested a review from kim-seonwoo June 7, 2024 02:36
@Zoe0929 Zoe0929 self-assigned this Jun 7, 2024
@Zoe0929 Zoe0929 linked an issue Jun 7, 2024 that may be closed by this pull request
Copy link
Member

@kim-seonwoo kim-seonwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고 많으셨습니다,,, 화이팅 좀 만 더!

Comment on lines +43 to +47
class AppStateViewModel: ObservableObject {
static let shared = AppStateViewModel()

@Published var showCustomAlert: Bool = false
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 이변수로 작동시키는 거군요!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵넵 이거 이어서 부탁드리겠습니다
혹시나 사용이 어렵다면 문의주세요 ☎️


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

하하 죄송합니다!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

control + i 한번씩 하기 ~

@Zoe0929 Zoe0929 merged commit f3b46fd into develop Jun 7, 2024
@Zoe0929 Zoe0929 changed the title [Feat/#44] 로직 점검 및 앱 잠금 연결 Feat [#44] 로직 점검 및 앱 잠금 연결 Jun 16, 2024
@Zoe0929 Zoe0929 deleted the network/#44 branch June 19, 2024 02:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
✨FEAT 기능 구현 🐰지희 지희의 issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Network] 챌린지뷰 네트워크 추가 연결
2 participants