From fb23e75826c55c3728001fa1f8f74e8a07daec87 Mon Sep 17 00:00:00 2001 From: TobiGr Date: Wed, 19 Jul 2023 23:38:36 +0200 Subject: [PATCH] Simply code by directly casting after instanceof in if-conditions --- .../newpipe/util/StreamItemAdapter.java | 20 +++++++++---------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/app/src/main/java/org/schabi/newpipe/util/StreamItemAdapter.java b/app/src/main/java/org/schabi/newpipe/util/StreamItemAdapter.java index 6682dce48f6..f37cef5ca88 100644 --- a/app/src/main/java/org/schabi/newpipe/util/StreamItemAdapter.java +++ b/app/src/main/java/org/schabi/newpipe/util/StreamItemAdapter.java @@ -136,8 +136,7 @@ private View getCustomView(final int position, int woSoundIconVisibility = View.GONE; String qualityString; - if (stream instanceof VideoStream) { - final VideoStream videoStream = ((VideoStream) stream); + if (stream instanceof VideoStream videoStream) { qualityString = videoStream.getResolution(); if (hasAnyVideoOnlyStreamWithNoSecondaryStream) { @@ -153,16 +152,15 @@ private View getCustomView(final int position, woSoundIconVisibility = View.INVISIBLE; } } - } else if (stream instanceof AudioStream) { - final AudioStream audioStream = ((AudioStream) stream); + } else if (stream instanceof AudioStream audioStream) { if (audioStream.getAverageBitrate() > 0) { qualityString = audioStream.getAverageBitrate() + "kbps"; } else { qualityString = context.getString(R.string.unknown_quality); } - } else if (stream instanceof SubtitlesStream) { - qualityString = ((SubtitlesStream) stream).getDisplayLanguageName(); - if (((SubtitlesStream) stream).isAutoGenerated()) { + } else if (stream instanceof SubtitlesStream subtitlesStream) { + qualityString = subtitlesStream.getDisplayLanguageName(); + if (subtitlesStream.isAutoGenerated()) { qualityString += " (" + context.getString(R.string.caption_auto_generated) + ")"; } } else { @@ -187,8 +185,8 @@ private View getCustomView(final int position, sizeView.setVisibility(View.GONE); } - if (stream instanceof SubtitlesStream) { - formatNameView.setText(((SubtitlesStream) stream).getLanguageTag()); + if (stream instanceof SubtitlesStream subtitlesStream) { + formatNameView.setText(subtitlesStream.getLanguageTag()); } else { if (mediaFormat == null) { formatNameView.setText(context.getString(R.string.unknown_format)); @@ -213,8 +211,8 @@ private View getCustomView(final int position, private boolean checkHasAnyVideoOnlyStreamWithNoSecondaryStream() { for (int i = 0; i < streamsWrapper.getStreamsList().size(); i++) { final T stream = streamsWrapper.getStreamsList().get(i); - if (stream instanceof VideoStream) { - final boolean videoOnly = ((VideoStream) stream).isVideoOnly(); + if (stream instanceof VideoStream videoStream) { + final boolean videoOnly = videoStream.isVideoOnly(); if (videoOnly && secondaryStreams.get(i) == null) { return true; }