Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Provide proper ISO 8601 timestamps in crash report emails #11865

Closed
6 tasks done
TheAssassin opened this issue Jan 1, 2025 · 1 comment · Fixed by #11887
Closed
6 tasks done

Provide proper ISO 8601 timestamps in crash report emails #11865

TheAssassin opened this issue Jan 1, 2025 · 1 comment · Fixed by #11887
Assignees
Labels
feature request Issue is related to a feature in the app

Comments

@TheAssassin
Copy link
Member

TheAssassin commented Jan 1, 2025

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

The crash report emails contain incomplete timestamps in an arbitrary format à la YYYY-mm-dd HH:MM. They should be sent in the ISO 8601 format.

Edit: We could directly normalize the time to UTC, too, but if it is sent in the ISO 8601 format, the timezone is encoded properly anyway and can be parsed.

Why do you want this feature?

While we don't need seconds precision, we need timestamp information. Glitchtip/Sentry/... reject timestamps that are in the future. Right now, the importer just discards such emails. Alternatively, we would have to replace the timestamp in the email with the current local time during the import, further reducing the accuracy.

Additional information

https://github.com/TeamNewPipe/CrashReportImporter/

CC @TobiGr

@TheAssassin TheAssassin added feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels Jan 1, 2025
@AudricV AudricV added good first issue Easy/simple issues perfect for newcomers to get involved in the project and removed needs triage Issue is not yet ready for PR authors to take up labels Jan 1, 2025
@Nikunj-Aggarwal
Copy link
Contributor

Could you please assign me this issue?

@ShareASmile ShareASmile removed the good first issue Easy/simple issues perfect for newcomers to get involved in the project label Jan 24, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature request Issue is related to a feature in the app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants