Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

OnFizzled output is not present on prop_weighted_cube but is somehow present on prop_floor_button #232

Closed
movercell opened this issue Aug 4, 2023 · 4 comments
Labels
bug done Fixed/implemented for next release FGD Concerns the entity definitions

Comments

@movercell
Copy link

Look at the name(i am not the only one who has the issue, my friend also has it)

@TeamSpen210
Copy link
Owner

Hmm weird that it’s not on cubes. It should be on buttons, the output is in fact available and functional on all model-based entities. Though obviously it’d be rather unlikely for a button to end up in a situation where it can be fizzled.

@TeamSpen210 TeamSpen210 added bug FGD Concerns the entity definitions labels Aug 4, 2023
@movercell
Copy link
Author

oh, but yeah it's strange it isn't on cubes

@The1stWii2
Copy link

It's because prop_floor_button inherits OnFizzled from BaseEntityAnimating, which isn't a base for prop_weighted_cube. The handful of other entities which have OnFizzled and don't inherit it from BaseEntityAnimating all manually define it.
It might be a good idea to add a definition to BaseEntityPhysics, of which, it seems, most other model-based entities inherit from.
inheritance

@TeamSpen210
Copy link
Owner

Ahh whoops, need to check why BasePropPhysics doesn't inherit from BaseEntityAnimating. It would in code.

@TeamSpen210 TeamSpen210 changed the title OnFIzzled Output is not present on prop_weighted_cube but is somehow present on prop_floor_button OnFizzled output is not present on prop_weighted_cube but is somehow present on prop_floor_button Aug 29, 2023
@TeamSpen210 TeamSpen210 changed the title OnFizzled output is not present on prop_weighted_cube but is somehow present on prop_floor_button OnFizzled output is not present on prop_weighted_cube but is somehow present on prop_floor_button Aug 29, 2023
@TeamSpen210 TeamSpen210 changed the title OnFizzled output is not present on prop_weighted_cube but is somehow present on prop_floor_button OnFizzled output is not present on prop_weighted_cube but is somehow present on prop_floor_button Aug 29, 2023
@TeamSpen210 TeamSpen210 added the done Fixed/implemented for next release label Aug 31, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug done Fixed/implemented for next release FGD Concerns the entity definitions
Projects
None yet
Development

No branches or pull requests

3 participants