Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Text styles shows up in view styles #18

Open
norman-ags opened this issue Sep 29, 2021 · 4 comments
Open

Text styles shows up in view styles #18

norman-ags opened this issue Sep 29, 2021 · 4 comments
Labels
help wanted Extra attention is needed typescript

Comments

@norman-ags
Copy link
Contributor

norman-ags commented Sep 29, 2021

When View is used in styled, the autocompletion shows Text styles, see screenshot below:

image

I think it should hide those styles similar to native view:
image

@Temzasse
Copy link
Owner

@norman-ags thanks for bringing this up 😊

This is definitely something I would like to improve but unfortunately the TypeScript side is very hard to modify because of the complexity of the types and my unfamiliarity with them. The types are basically copied from the main Stitches repo and modified to work with React Native so it's quite challenging to make modifications to them without breaking them.

I'm quite sure the source of this is the ReactNativeProperties type that wraps all the possible RN CSS properties into one type but I'm not sure how to break it apart and how to modify the complex types to take this into account. I can try to investigate this but it would be super helpful if someone from the Stitches team or someone that is very good at TS could give a hand/hint about this 🙂

@norman-ags
Copy link
Contributor Author

Thanks @Temzasse. I would like to help you out but I'm just new on TS.

@Temzasse
Copy link
Owner

@norman-ags did you by any chance have the time to investigate this issue any further? 🙂

I have been tackling some other TS issues but I haven't been able to resolve this one just yet due to lack of time 🙁

@norman-ags
Copy link
Contributor Author

Sorry for the late reply. Same here, lack of time.

@Temzasse Temzasse added help wanted Extra attention is needed typescript labels Aug 21, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
help wanted Extra attention is needed typescript
Projects
None yet
Development

No branches or pull requests

2 participants