Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support comments from Doc​Blockr #6

Closed
mauroreisvieira opened this issue Mar 9, 2020 · 13 comments
Closed

Support comments from Doc​Blockr #6

mauroreisvieira opened this issue Mar 9, 2020 · 13 comments
Labels
enhancement New feature or request

Comments

@mauroreisvieira
Copy link

Hi @TheSecEng it's very good plugin.

Your plugin can support this kind of comments?

Screenshot 2020-03-09 at 09 47 01

@TerminalFi
Copy link
Owner

To ensure I understand , both sentences should be highlighted ?

@mauroreisvieira
Copy link
Author

No, I talk about @param and {string}.

The description it's good as is.

@TerminalFi
Copy link
Owner

No, I talk about @param and {string}.

The description it's good as is.

Sure just add @param as the identifier and it should work as expected. If you wait till I update it today it will also resolve some issues with color scheme generation that I overlooked before.

@mauroreisvieira
Copy link
Author

mauroreisvieira commented Mar 9, 2020

Ok, I try but not work as expected.

Screenshot 2020-03-09 at 13 56 21

Is not possible to use the variables form the scheme?

instead of region.greenish using the var(green) directly?

by the way, I wait for your next update.

@TerminalFi
Copy link
Owner

Ok, I try but not work as expected.

Screenshot 2020-03-09 at 13 56 21

Is not possible to use the variables form the scheme?

instead of region.greenish using the var(green) directly?

by the way, I wait for your next update.

Currently no, the update will contain this feature

@TerminalFi
Copy link
Owner

@mauroreisvieira I've pushed changes and issued a new release that supports variables by removing color validation and relying on ST to do that as they already do.

You can either wait from PackageControl to re-pull the new release or do a git clone git@github.com:TheSecEng/ColoredComments.git "Colored Comments" into your Packages directory.

@TerminalFi
Copy link
Owner

Although, I just noticed multiline comments don't get treated correctly, so it appears I have more work to do 😄

2020-03-09_12-32-22

The colors are getting triggered on the * which is wrong. So I will work on this tonight

@mauroreisvieira
Copy link
Author

Yeh. My idea it's only set the color to @param and the type. :)

@TerminalFi TerminalFi added the enhancement New feature or request label Mar 9, 2020
@TerminalFi
Copy link
Owner

Yeh. My idea it's only set the color to @param and the type. :)

Awesome, v2.0.4 will have a fix for this by supporting regex inside of the identifier.

@TerminalFi
Copy link
Owner

@mauroreisvieira fix is delayed, in the mean time you can make an identifier like "* @param" and it will work.

@TerminalFi
Copy link
Owner

Resolved in #7

@TerminalFi
Copy link
Owner

TerminalFi commented Mar 12, 2020

@mauroreisvieira once PackageControl updates Colored Comments to 2.1.0 I recommend you write a tag like this for multiple matching.

"@Param":
{
	"color":
	{
		"background": "rgba(1,22,38, 0.1)",
		"foreground": "#00cc00",
		"name": "Param"
	},
	"identifier": "[\\*]?[ ]?@param",
	"is_regex": true,
	"priority": "-9999"
}

I am sure you know but the ? make those characters optional for matching which is what allows it to match both @param and * @param
It will allow you to match the following cases.

/*
@param MyFunction
* @param MyFunction
*/

2020-03-11_21-30-23

@mauroreisvieira
Copy link
Author

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants