From a1a575e26f9e85e365eebc1de9d272823c989787 Mon Sep 17 00:00:00 2001
From: Nabil Adouani <nabil.adouani@gmail.com>
Date: Fri, 24 Apr 2020 13:04:22 +0200
Subject: [PATCH] #962 Display responder job errors

---
 ui/app/scripts/directives/responder-actions.js |  8 +++++++-
 ui/app/styles/case.css                         | 10 ++++++++++
 ui/app/views/directives/responder-actions.html | 11 +++++++++--
 3 files changed, 26 insertions(+), 3 deletions(-)

diff --git a/ui/app/scripts/directives/responder-actions.js b/ui/app/scripts/directives/responder-actions.js
index 0904af5269..e288bd2e1c 100644
--- a/ui/app/scripts/directives/responder-actions.js
+++ b/ui/app/scripts/directives/responder-actions.js
@@ -8,8 +8,14 @@
                 actions: '=',
                 header: '@'
             },
-            templateUrl: 'views/directives/responder-actions.html',            
+            templateUrl: 'views/directives/responder-actions.html',
             controller: function($scope, $uibModal) {
+                _.each($scope.actions.values, function(action) {
+                    if(action.status === 'Failure') {
+                        action.errorMessage = (JSON.parse(action.report) || {}).errorMessage;
+                    }
+                });
+
                 $scope.showResponderJob = function(action) {
                     $uibModal.open({
                         scope: $scope,
diff --git a/ui/app/styles/case.css b/ui/app/styles/case.css
index 9caab9d482..3e708d3858 100644
--- a/ui/app/styles/case.css
+++ b/ui/app/styles/case.css
@@ -80,3 +80,13 @@ table.case-list .case-tags .label,
     font-size: 12px !important;
     font-weight: normal;
 }
+
+pre.error-trace {
+  color: #a94442;
+  border: none;
+  font-size: 10px;
+  word-wrap: break-word;
+  word-break: break-all;
+  white-space: pre-wrap;
+  background-color: #f9f1f1;
+}
diff --git a/ui/app/views/directives/responder-actions.html b/ui/app/views/directives/responder-actions.html
index c2d7627c66..6394b5ab62 100644
--- a/ui/app/views/directives/responder-actions.html
+++ b/ui/app/views/directives/responder-actions.html
@@ -18,11 +18,18 @@ <h4 class="text-primary">{{header}}</h4>
                     'InProgress': 'label-warning',
                     'Failure': 'label-danger'}[action.status]">{{action.status}}</span>
                 </td>
-                <td>{{action.responderName}}</td>
+                <td>
+                    <div>{{action.responderName}}</div>
+                    <div ng-if="action.status === 'Failure'" class="text-danger wrap mt-xxs">
+                        <a class="text-danger" href
+                            ng-click="action.showError = !!!action.showError">{{action.showError ? 'Hide' : 'Show'}} error</a>
+                        <pre ng-show="action.showError" class="error-trace">{{action.errorMessage}}</pre>
+                    </div>
+                </td>
                 <td>{{action.cortexId}}</td>
                 <td>{{action.startDate | shortDate}}</td>
                 <td class="text-center">
-                    <a href class="noline" ng-click="showResponderJob(action)"><i class="fa fa-search"></i></a>
+                    <a ng-if="action.status !== 'Failure'" href class="noline" ng-click="showResponderJob(action)" uib-tooltip="Show action report" tooltip-placement="left-middle"><i class="fa fa-search"></i></a>
                 </td>
             </tr>
         </tbody>