Merge pull request #1992 from jenshandersson/feat/hlssize

jenshandersson · web-flow · commit c579d3cddd11 · 2020-05-05T18:16:28.000+02:00
Fix video dimensions for HLS streams
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ### Version 5.1.0-alpha6
 
 - Fix iOS bug which would break size of views when video is displayed with controls on a non full-screen React view. [#1931](https://github.com/react-native-community/react-native-video/pull/1931)
+- Fix video dimensions being undefined when playing HLS in ios. [#1992](https://github.com/react-native-community/react-native-video/pull/1992)
 
 ### Version 5.1.0-alpha5
 
diff --git a/ios/Video/RCTVideo.m b/ios/Video/RCTVideo.m
@@ -638,6 +638,10 @@ - (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(N
           } else {
             orientation = @"portrait";
           }
+        } else if (_playerItem.presentationSize.height) {
+          width = [NSNumber numberWithFloat:_playerItem.presentationSize.width];
+          height = [NSNumber numberWithFloat:_playerItem.presentationSize.height];
+          orientation = _playerItem.presentationSize.width > _playerItem.presentationSize.height ? @"landscape" : @"portrait";
         }
         
         if (self.onVideoLoad && _videoLoadStarted) {

Original file line number	Diff line number	Diff line change
`@@ -638,6 +638,10 @@ - (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(N`
`638`	`638`	`} else {`
`639`	`639`	`orientation = @"portrait";`
`640`	`640`	`}`
	`641`	`+ } else if (_playerItem.presentationSize.height) {`
	`642`	`+ width = [NSNumber numberWithFloat:_playerItem.presentationSize.width];`
	`643`	`+ height = [NSNumber numberWithFloat:_playerItem.presentationSize.height];`
	`644`	`+ orientation = _playerItem.presentationSize.width > _playerItem.presentationSize.height ? @"landscape" : @"portrait";`
`641`	`645`	`}`
`642`	`646`
`643`	`647`	`if (self.onVideoLoad && _videoLoadStarted) {`