Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improve stability of plugin enabling/disabling #117

Open
ThomasTJdev opened this issue Sep 7, 2019 · 0 comments
Open

Improve stability of plugin enabling/disabling #117

ThomasTJdev opened this issue Sep 7, 2019 · 0 comments
Labels
enhancement New feature or request next Might become the Next Release

Comments

@ThomasTJdev
Copy link
Owner

CC @juancarlospaco, what do you think?

Our recompile function is sometimes unstable. Suggestion:

  1. Activate recompile from the browser UI
  2. NimWC launcher stops nimwc_main subrunner
  3. NimWC launcher moves nimwc_main to a backup location
  4. NimWC launcher runs startupCheck(), which will recompile nimwc_main
  5. If recompiling fails, NimWC launcher will move the backup of nimwc_main back and report the output of the compiling error

Using the method above, we will keep the recompling out of the subrunner, and NimWC launcher will be in control.
@juancarlospaco juancarlospaco added the enhancement New feature or request label Sep 7, 2019
@juancarlospaco juancarlospaco added the next Might become the Next Release label Dec 27, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement New feature or request next Might become the Next Release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@juancarlospaco @ThomasTJdev