Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Does not compile against recaptcha@#head #136

Open
c-blake opened this issue Oct 6, 2020 · 2 comments
Open

Does not compile against recaptcha@#head #136

c-blake opened this issue Oct 6, 2020 · 2 comments
Labels
good first issue Good for newcomers

Comments

@c-blake
Copy link

c-blake commented Oct 6, 2020

The recaptcha library added a second overload for initRecaptcha. Consequently, nimwcpkg/webs/captchas.nim:setupReCaptcha must provide a third argument (either a bool or a Provider) for Nim to unambiguously resolve the call. This will matter more once recaptcha stamps a new release. You may want a when compiles guard to handle both old & new recaptcha libs.

@ThomasTJdev
Copy link
Owner

Hi @c-blake

Good catch and thank you!! Actually, I should have noticed this, since I made the PR 🍡 euantorano/recaptcha.nim@0c471d2

@ThomasTJdev ThomasTJdev added the good first issue Good for newcomers label Oct 7, 2020
@c-blake
Copy link
Author

c-blake commented Oct 7, 2020

I found it compiling a big chunk of The Nimbleverse to test https://github.com/c-blake/nimp. Nimble uses latest tagged releases while nimp uses #head all the time, really..(or whenever the installer last did nimp up for all their packages).

I started to "patch/fix" said Nimbleverse before deciding to compare how much regular nimble failed - which was "also a lot". :-) The main Nim does important packages CI, but 30-40% of "wider world" packages just break from neglect. { I do not think nimble devs test against the 1350 packages they could. The onus is instead upon package authors to test nimble. }

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants