Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Refactor: Reduce internal use of String types in favor of Symbols #97

Closed
rdboyes opened this issue Apr 29, 2024 · 0 comments · Fixed by #118
Closed

Refactor: Reduce internal use of String types in favor of Symbols #97

rdboyes opened this issue Apr 29, 2024 · 0 comments · Fixed by #118
Assignees
@rdboyes
Labels
enhancement New feature or request

Comments

@rdboyes
Copy link
Member

rdboyes commented Apr 29, 2024

Describe how it works in R's ggplot2
Package internal Dicts use a mix of string keys and symbol keys, causing unnecessary confusion. Lets convert all keys to symbols as early as possible.
@rdboyes rdboyes added the enhancement New feature or request label Apr 29, 2024
@rdboyes rdboyes self-assigned this Apr 29, 2024
@rdboyes rdboyes mentioned this issue Sep 17, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@rdboyes rdboyes

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

You wouldnt pirate a type TidierOrg/TidierPlots.jl
1 participant
@rdboyes