Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Feat: Standardize handling of terminations and phases #1347

Open
triceo opened this issue Jan 23, 2025 · 0 comments
Open

Feat: Standardize handling of terminations and phases #1347

triceo opened this issue Jan 23, 2025 · 0 comments
Labels
enhancement New feature or request process/needs triage Requires initial assessment of validity, priority etc.

Comments

@triceo
Copy link
Contributor

triceo commented Jan 23, 2025 •
edited
Loading

The following terminations must not terminate the construction heuristics:

  • Unimproved terminations
  • Step count terminations
  • Diminished Returns termination

Some of them throw exceptions when enabled on a CH. The desired result is:

  • All of these terminations can be configured on the global level.
  • All of these terminations understand which phases they should ignore.
  • The mechanism by which this is achieved is the same for all terminations.
  • Termination either becomes public API, or we decide that terminations are not and never will be user-facing, in which case we seal the entire class hierarchy.
@triceo triceo added enhancement New feature or request process/needs triage Requires initial assessment of validity, priority etc. labels Jan 23, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement New feature or request process/needs triage Requires initial assessment of validity, priority etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@triceo