Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add video output types option #17

Open
phuchptty opened this issue Jun 15, 2022 · 3 comments
Open

Add video output types option #17

phuchptty opened this issue Jun 15, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@phuchptty
Copy link
Contributor

It would be great if support various output types like mp4, flv,...
and why don't use ffmpeg instead of mkvmerge ?

@ToaHartor
Copy link
Owner

mkvmerge was used instead of FFMPEG purely by design choice (I was more familiar with it and because the job was only to make mkv files), but I should be able to make a wrapper for FFMPEG for those who prefer to use it. Another native solution to make MKV files is also currently being developed, for those who don't have (or want to install) either softwares.

As for other outputs, many don't support multiple audio files or ASS softsubs, or not as much as mkv files are able to. Some people might want to burn the subtitles, or only have one audio track, and enabling those formats depending on the use case adds some complexity to the program. But I think it should be possible to use FFMPEG with the merged mkv as the input to make a MP4 file with one audio and the subtitles burned in.

FFMPEG may enable other formats support, but the more flexible of them remains mkv in my opinion. MP4 could be another supported format (as more widely supported I believe), but the problematic here is the support of ASS subtitles files (I could be wrong there but the only possibility is to burn them in the video, and I don't want to re-encode it). If I add a wrapper for FFMPEG, it might be possible to output a MP4 file. However for the other formats I would need some examples and see if it's relevant to support.

@phuchptty
Copy link
Contributor Author

Thanks for the reply. I hope it will available soon

@ToaHartor ToaHartor added the enhancement New feature or request label Jun 17, 2022
@ToaHartor ToaHartor added this to the v0.4.0 milestone Jul 2, 2022
@ToaHartor
Copy link
Owner

FFMPEG support will be added in v0.4.0, but the support for other file types might come a bit later (as it requires some modifications in the way the CLI works). Since the CLI will be heavily modified for the next version, it should be implemented there.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants