Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Properties cleanup and method bodies to expressions #1

Open
charles-peter-nystrom opened this issue Jun 2, 2021 · 2 comments
Open

Properties cleanup and method bodies to expressions #1

charles-peter-nystrom opened this issue Jun 2, 2021 · 2 comments

Comments

@charles-peter-nystrom
Copy link
Contributor

I noticed several local values are being used like properties and there are several places with duplicated code that could be better expressed using member expressions. There are several names that don't follow C# naming conventions as well.

@Tobiti I've made a fork and started working on cleaning it up. When I'm done I'll send a pull request for you to review. In the meantime you can follow my changes if you'd like.
@Tobiti
Copy link
Owner

Tobiti commented Jun 2, 2021

I don't like the c# conventions, so I use my own.
And I have merged the newest branch in it so pls pull the newest version and later create a pull request :)

@charles-peter-nystrom
Copy link
Contributor Author

PR created and submitted for approval :D

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@charles-peter-nystrom @Tobiti