Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature request: authentication support for proxies #1682

Open
anthonybilinski opened this issue Feb 9, 2021 · 3 comments · May be fixed by #1683
Open

Feature request: authentication support for proxies #1682

anthonybilinski opened this issue Feb 9, 2021 · 3 comments · May be fixed by #1683
Assignees
Labels
P3 Low priority
Milestone

Comments

@anthonybilinski
Copy link

Carrying over from irungentoo#1268.

Clients have gotten requests to support authenticated proxies, e.g.:
JFreegman/toxic#371
qTox/qTox#1286

I recognize that as nurupoo mentioned the authentication isn't encrypted with SOCKS5, but we've still had a few duplicate issues for qTox alone, and at least corporate proxies seems like a reasonable use case.

@nurupo nurupo linked a pull request Feb 13, 2021 that will close this issue
@iphydf iphydf added the P3 Low priority label Feb 4, 2022
@iphydf iphydf added this to the v0.2.x milestone Feb 5, 2022
@iphydf iphydf modified the milestones: v0.2.x, v0.2.17 Feb 6, 2022
@iphydf iphydf modified the milestones: v0.2.17, v0.2.18, v0.2.19 Feb 24, 2022
@iphydf iphydf modified the milestones: v0.2.19, v0.2.20 Apr 18, 2022
@emdee-is
Copy link

emdee-is commented Feb 4, 2024

There's not much work involved in negotiating authentication in SOCKS.
It would mean adding SOCKS_USER and SOCKS_PASSWORD fields to the ToxOptions. Ideally the iterate code should recheck the authentification and reauthenticate if necessary as corporate proxies often have short timeouts.

You should add support for a comma seperated list of IP:port for NO_PROXY.

@iphydf
Copy link
Member

iphydf commented Feb 4, 2024

#1683

@emdee-is
Copy link

emdee-is commented Feb 4, 2024

@iphydf Great I missed that. Can you add a comment to the PR the say what the state of the PR is and what it needs to be merged?

Once it lands I can easily modify my testrunner to support SOCKS username and password https://git.plastiras.org/emdee/toxygen_wrapper/src/branch/main/src/tox_wrapper/tests/tests_wrapper.py

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
P3 Low priority
Development

Successfully merging a pull request may close this issue.

4 participants