Skip to content

Commit

Permalink
5.0.0
Browse files Browse the repository at this point in the history
  • Loading branch information
@TooTallNate
TooTallNate committed Feb 7, 2020
1 parent 0379e01 commit 8fdb1a5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "https-proxy-agent",
"version": "4.0.0",
"version": "5.0.0",
"description": "An HTTP(s) proxy `http.Agent` implementation for HTTPS",
"main": "dist/index",
"types": "dist/index",
Expand Down

5 comments on commit 8fdb1a5

@DanielRuf
Copy link

@DanielRuf DanielRuf commented on 8fdb1a5 Feb 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why the major bump was done even if the API for users and consumers has not changed and there are no breaking changes (SemVer).

@DanielRuf
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for 4.0.0 ;-)

@mokimo
Copy link

@mokimo mokimo commented on 8fdb1a5 Feb 12, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather one breaking change too much instead of accidentally pushing one when unsure imo

@DanielRuf
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure but this prevented that the default SemVer ranges ^ and ~ picked this version up.

@vogsphar
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IT also scares user from upgrading. i.e. node-red is still on 2.2.4.
It would also be nice to flag 2.2.4, so that users can see that this contains a security issue.

Please # to comment.