Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove unused debug dependency #358

Closed
alexparish opened this issue Dec 7, 2024 · 2 comments · Fixed by #359
Closed

Remove unused debug dependency #358

alexparish opened this issue Dec 7, 2024 · 2 comments · Fixed by #359

Comments

@alexparish
Copy link
Contributor

It seems the debug dependency in the agent-base package is no longer used. Can it be removed?

Happy to raise a PR for this.
@lukekarrys
Copy link
Collaborator

Please do! If you see any other cleanup stuff as well I'd be happy to see other PRs 😄 Running https://knip.dev on the repo might be interesting too 🤔

@alexparish alexparish mentioned this issue Dec 7, 2024
Merged
@alexparish
Copy link
Contributor Author

alexparish commented Dec 7, 2024 •
edited
Loading

Great minds... I actually ran knip and found debug but no other unused dependencies. There was a long list of unused devDependencies reported. I didn't go through them, but they could have been false positives.

PR for removing debug: #359

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[agent-base] Remove unused debug dependency alexparish/proxy-agents
2 participants
@alexparish @lukekarrys