From a74ab99126dcdaef54e016bfa2200d13acea3599 Mon Sep 17 00:00:00 2001
From: Luigi Pinca <luigipinca@gmail.com>
Date: Mon, 27 Jan 2020 18:29:59 +0100
Subject: [PATCH] Push the EOF signaling `null` chunk after replaying proxy
 errors

Allow the `'end'` event to be emitted on the `http.IncomingMessage`
instance.

Fixes: https://github.com/TooTallNate/node-https-proxy-agent/issues/87
---
 index.js     |  1 +
 test/test.js | 22 ++++++++++++++++++++++
 2 files changed, 23 insertions(+)

diff --git a/index.js b/index.js
index aa3021e2..a5e44a39 100644
--- a/index.js
+++ b/index.js
@@ -187,6 +187,7 @@ HttpsProxyAgent.prototype.callback = function connect(req, opts, fn) {
 		// replay the "buffers" Buffer onto the `socket`, since at this point
 		// the HTTP module machinery has been hooked up for the user
 		socket.push(buffers);
+		socket.push(null);
 
 		// nullify the cached Buffer instance
 		buffers = null;
diff --git a/test/test.js b/test/test.js
index c309c812..50d9e23f 100644
--- a/test/test.js
+++ b/test/test.js
@@ -251,6 +251,28 @@ describe('HttpsProxyAgent', function() {
 
 			req.on('abort', done);
 		});
+		it('should emit an "end" event on the `http.IncomingMessage` if the proxy responds with non-200 status code', function(done) {
+			proxy.authenticate = function(req, fn) {
+				fn(null, false);
+			};
+
+			const proxyUri =
+				process.env.HTTP_PROXY ||
+				process.env.http_proxy ||
+				'http://localhost:' + proxyPort;
+
+			const req = http.get(
+				{
+					agent: new HttpsProxyAgent(proxyUri)
+				},
+				function(res) {
+					assert.equal(407, res.statusCode);
+
+					res.resume();
+					res.on('end', done);
+				}
+			);
+		});
 		it('should emit an "error" event on the `http.ClientRequest` if the proxy does not exist', function(done) {
 			// port 4 is a reserved, but "unassigned" port
 			var proxyUri = 'http://localhost:4';