Skip to content
This repository has been archived by the owner on Dec 7, 2022. It is now read-only.

Refactor lib/utils.js #54

Open
jacobmoretti opened this issue Oct 28, 2017 · 2 comments
Open

Refactor lib/utils.js #54

jacobmoretti opened this issue Oct 28, 2017 · 2 comments

Comments

@jacobmoretti
Copy link
Collaborator

Refactor lib/utils.js by abstracting out each of the functions into separate files and placed under lib:

  • getLocation, I believe this was only added to allow easier mocking. We should be able to do away with this and fix the tests that relied on it.
  • ldClientWrapper -> ldClientWrapper.js
  • ldOverrideFlag -> ldOverrideFlag.js
  • getAllFeatureFlags -> getAllFeatureFlags.js
@GarretLefler
Copy link

GarretLefler commented Oct 29, 2017

I can help with this.

Is there a quick way to test any changes I make before I submit a pull request?

@jacobmoretti
Copy link
Collaborator Author

@GarretLefler Thanks for offering to lend a hand with this issue! Unfortunately there isn't a great a way to do an end-to-end test without an account with LaunchDarkly. Its also part of the reason why #16 hasn't been completed yet.

Feel free to submit your PR and use the unit-tests as the measurement for now. I'll do some testing of your changes on my end as well.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

2 participants