Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make sure that inactive assets (and their flows) are removed from the model #266

Closed
abelsiqueira opened this issue Nov 17, 2023 · 6 comments · Fixed by #1027
Closed

Make sure that inactive assets (and their flows) are removed from the model #266

abelsiqueira opened this issue Nov 17, 2023 · 6 comments · Fixed by #1027

Comments

@abelsiqueira
Copy link
Member

abelsiqueira commented Nov 17, 2023

When inactive (false in the active column from assets-data.csv), the asset and related flows should not be present in the model.
This needs a test that changes the solution.

@clizbe
Copy link
Member

clizbe commented Jan 11, 2024

Is this something we should program specifically, or is this something more general that'll happen when reading in and processing the data? Seems like there might be other reasons to filter things out as well.

@abelsiqueira
Copy link
Member Author

At the time, the idea was that if an asset is inactive, then it should not be included in the graph. That implies that flows that go to and from that asset are not included in the graph.
We were thinking about reading the CSV, but indeed it could happen in more general places.
I imagine active is part of the scenario, so it might be that this option is better processed separately from the CSV reading.
That being said, we can always move the logic elsewhere.

@clizbe
Copy link
Member

clizbe commented Feb 15, 2024

Would this now be a sub-issue of #461?

@abelsiqueira
Copy link
Member Author

It might be related, but I think active will be moved to the "default scenario" specification or something like that, because it is not part of the input data, right?

@clizbe
Copy link
Member

clizbe commented Feb 16, 2024

It's a parameter in ESDL... but is also something we might want to change between scenarios...

@datejada
Copy link
Member

with #1027 we don't need this issue anymore

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants