Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Navigation does not remember scroll position #2626

Closed
Gerrit0 opened this issue Jul 5, 2024 · 1 comment
Closed

Navigation does not remember scroll position #2626

Gerrit0 opened this issue Jul 5, 2024 · 1 comment
Milestone

Comments

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Jul 5, 2024

Hello @Gerrit0,

I have encountered an issue related to the navigation and the changes made in commit 9751e31. Specifically, the navigation scrollbar keeps scrolling up on each page refresh. You can see a demonstration of this issue in Issue #2624.

I saw you solved this issue, but I observed that the navigation scrolling happens only when the navigation is not visible, which seems to be due to the negation in the visibility check !pageLink.checkVisibility().

Does this negation serve a specific purpose?

Originally posted by @dom-rau in #2491 (comment)

@Gerrit0
Copy link
Collaborator Author

Gerrit0 commented Jul 5, 2024

#2624 is an entirely different issue, it is for TypeDoc's doc site which uses eleventy, not the API documentation generated by TypeDoc, (https://typedoc.org/guides/overview/, not https://typedoc.org/api/)

That negation was intended to only scroll the navigation if the page link wasn't already on the screen, which isn't the right way to check that... I incorrectly assumed that the method checked if the element was... visible...

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant